Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: split commands/workspace.rs into sub modules #4172

Merged
merged 3 commits into from
Jul 31, 2024
Merged

cli: split commands/workspace.rs into sub modules #4172

merged 3 commits into from
Jul 31, 2024

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Jul 28, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

yuja added 3 commits July 28, 2024 23:02
@yuja
cli: duplicate cmd_workspace_root() to cmd_root()
9d43df2 
Suppose cmd_root() will gain options to print other kind of root paths, it's
probably simpler to inline path handling there instead of turning cmd_root()
into a dispatcher function. If cmd_root() remains with the current form, maybe
we can add aliases.root = ["workspace", "root"] instead.
@yuja
cli: split commands/workspace.rs into sub modules
bcd7a5f
@yuja
cli: move cmd_workspace_update_stale() entry point next to Args struct
37450a0
@yuja yuja force-pushed the push-zknxtvpooswv branch from 0f3625f to 37450a0 Compare July 28, 2024 14:14
PhilipMetzger
PhilipMetzger approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/src/commands/workspace/update_stale.rs Outdated Show resolved Hide resolved
@yuja yuja merged commit b2b8682 into jj-vcs:main Jul 31, 2024
17 checks passed
@yuja yuja deleted the push-zknxtvpooswv branch July 31, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipMetzger PhilipMetzger PhilipMetzger approved these changes

@ilyagr ilyagr ilyagr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuja @ilyagr @PhilipMetzger