Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: fix: replace obsolete todo with a new one #4169

Merged
merged 1 commit into from
Jul 29, 2024
Merged

cli: fix: replace obsolete todo with a new one #4169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions cli/src/commands/fix.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,8 @@ pub(crate) fn cmd_fix(
// We currently only support fixing the content of normal files, so we skip
// directories and symlinks, and we ignore the executable bit.
if let TreeValue::File { id, executable: _ } = term {
// TODO: Consider filename arguments and tool configuration instead of
// passing every changed file into the tool. Otherwise, the tool has to
// be modified to implement that kind of stuff.
// TODO: Skip the file if its content is larger than some configured size,
// preferably without actually reading it yet.
let tool_input = ToolInput {
file_id: id.clone(),
repo_path: repo_path.clone(),
Expand Down