Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: merge op heads and snapshot working copy by "op log" by default #4165

Merged
merged 5 commits into from
Aug 3, 2024

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Jul 26, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

cli/src/cli_util.rs Outdated Show resolved Hide resolved
cli/src/cli_util.rs Outdated Show resolved Hide resolved
cli/src/commands/operation/log.rs Show resolved Hide resolved
@yuja yuja force-pushed the push-tssptnpsllnk branch 2 times, most recently from dccdee0 to dfd7cf4 Compare July 28, 2024 04:52
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, FWIW.

yuja added 5 commits August 1, 2024 22:52
The current "op abandon" and "op log" have workarounds to recover from this
situation. Let's make sure they work as expected.
The idea is that --at-op specifies a certain operation, so --at-op=@ can be
interpreted as the option to select _the_ known head operation. This helps
eliminate special cases from "op log" which doesn't snapshot nor merge
concurrent ops.
Now heads merging can be turned off by --at-op=@.
This partially reverts 543036c "cli: run 'op log' without loading repo or
merging concurrent ops." User can now get around the issue by --at-op=@
--ignore-working-copy.
@yuja yuja force-pushed the push-tssptnpsllnk branch from dfd7cf4 to 36b4992 Compare August 1, 2024 13:54
@yuja yuja merged commit 9ec6175 into jj-vcs:main Aug 3, 2024
17 checks passed
@yuja yuja deleted the push-tssptnpsllnk branch August 3, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants