-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: rename obslog
to evolution
#4146
Conversation
e8d111c
to
9d35a0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. BTW, I wonder if jj evolution
should be able to take a revset argument without requiring -r
like several other commands do... We can save that for a follow up though, and the -r
handling of those other commands I mention need to be fixed up a little.
What do you think about command like |
Which commands do you mean? I probably missed a conversation somewhere.
Let's not open the |
That sounds too similar to what I'll leave this PR open for a while to give you and others more opportunity to comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This SGTM, it should also be easy to access as jj evo<TAB>
, assuming we don't plan to have any other evolution
-related commands. I can't really think of any at the moment.
If we could think of some, I'd go for jj evolution log
, jj evolog
for short.
My only concern is that |
I agree with that but I couldn't think of a better name that people seemed to like. I'd be fine with |
If we're looking for verbs, there is also chronicle, which happens to also be a noun. |
Looking up the synonyms of evolution, I found |
I slightly prefer |
Does |
Yes, but also, it would mean the same thing. This is for the command that shows how "changes" have evolved (through different revisions).
|
I'm aware. Save for potential confusion with |
Another couple of colors to consider for the shed: change-history and revision-history. These are nouns, though. |
For everyone here's the prior discussion: #3592 |
What if it's just |
I wouldn't mind Either way, I like the "evo" prefix, and would like Looking back at the discussion Philip linked, I still like "rewritelog" a bit, but less. The problem with that is that Even though |
I think this is also a good idea. It would provide a good UX if we can make it work. The downside is that we'd have to make So, my first reaction is that I think I'd prefer |
I wonder whether it should take a path argument, like |
I don't think all the options would have to apply, if you make them mutually exclusive. The templates would need to match maybe? |
If we don't take the
While this works, I'd rather not mix concepts as the "Change's" evolution is separate from a repo's history. I also think this will hinder learning Jujutsu. |
I'm going to go with |
It seems everyone agrees that `obslog` is not an intuitive name. There was some discussion about alternatives in #3592 and on #4146. The alternatives included `evolution`, `evolutionlog`, `evolog`, `rewritelog`, `revlog`, and `changelog`. It seemed like `evolution-log`/`evolog` was the most popular option. That also matches the command's current help text ("Show how a change has evolved over time").
9d35a0e
to
0ce0148
Compare
I've updated this to use |
I personally rather liked just |
It seems everyone agrees that `obslog` is not an intuitive name. There was some discussion about alternatives in #3592 and on #4146. The alternatives included `evolution`, `evolutionlog`, `evolog`, `rewritelog`, `revlog`, and `changelog`. It seemed like `evolution-log`/`evolog` was the most popular option. That also matches the command's current help text ("Show how a change has evolved over time").
0ce0148
to
c25a9f6
Compare
It seems everyone agrees that `obslog` is not an intuitive name. There was some discussion about alternatives in #3592 and on #4146. The alternatives included `evolution`, `evolutionlog`, `evolog`, `rewritelog`, `revlog`, and `changelog`. It seemed like `evolution-log`/`evolog` was the most popular option. That also matches the command's current help text ("Show how a change has evolved over time").
c25a9f6
to
5701759
Compare
It seems everyone agrees that `obslog` is not an intuitive name. There was some discussion about alternatives in #3592 and on #4146. The alternatives included `evolution`, `evolutionlog`, `evolog`, `rewritelog`, `revlog`, and `changelog`. It seemed like `evolution-log`/`evolog` was the most popular option. That also matches the command's current help text ("Show how a change has evolved over time").
5701759
to
0ea9444
Compare
It seems everyone agrees that `obslog` is not an intuitive name. There was some discussion about alternatives in #3592 and on #4146. The alternatives included `evolution`, `evolutionlog`, `evolog`, `rewritelog`, `revlog`, and `changelog`. It seemed like `evolution-log`/`evolog` was the most popular option. That also matches the command's current help text ("Show how a change has evolved over time").
0ea9444
to
ae5598e
Compare
It seems everyone agrees that `obslog` is not an intuitive name. There was some discussion about alternatives in #3592 and on #4146. The alternatives included `evolution`, `evolutionlog`, `evolog`, `rewritelog`, `revlog`, and `changelog`. It seemed like `evolution-log`/`evolog` was the most popular option. That also matches the command's current help text ("Show how a change has evolved over time").
ae5598e
to
8fca7a5
Compare
I'll merge this now |
Checklist
If applicable:
CHANGELOG.md