Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: build with crt-static on windows #4096

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

thoughtpolice
Copy link
Collaborator

@thoughtpolice thoughtpolice commented Jul 15, 2024

Avoids a runtime dependency on vcruntime140.dll.

Closes #4005.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@thoughtpolice thoughtpolice force-pushed the aseipp/push-qomnnttnpxss branch from 902b634 to e136cda Compare July 15, 2024 23:48
@thoughtpolice
Copy link
Collaborator Author

Tested with binaries from main on my fork: https://github.com/thoughtpolice/jj/actions/runs/9948152804

@thoughtpolice thoughtpolice force-pushed the aseipp/push-qomnnttnpxss branch from e136cda to acddfae Compare July 17, 2024 12:20
Avoids a runtime dependency on vcruntime140.dll

Signed-off-by: Austin Seipp <[email protected]>
@thoughtpolice thoughtpolice force-pushed the aseipp/push-qomnnttnpxss branch from acddfae to cf5fde8 Compare July 17, 2024 12:21
@thoughtpolice thoughtpolice merged commit 6c54b66 into main Jul 17, 2024
29 checks passed
@thoughtpolice thoughtpolice deleted the aseipp/push-qomnnttnpxss branch July 17, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows binaries require vcruntime140.dll to be installed
2 participants