Add multi-tool config for jj fix
#4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hooper
force-pushed
the
push-opqkpoomxpyq
branch
from
bd538e3 to
59b3d99
Compare
yuja
reviewed
Jul 13, 2024
hooper
force-pushed
the
push-opqkpoomxpyq
branch
from
59b3d99 to
0eb882e
Compare
yuja
approved these changes
Jul 17, 2024
hooper
force-pushed
the
push-opqkpoomxpyq
branch
7 times, most recently
from
e1e9db2 to
6ad70f9
Compare
PhilipMetzger
approved these changes
Jul 23, 2024
hooper
force-pushed
the
push-opqkpoomxpyq
branch
2 times, most recently
from
8224c47 to
a5d6ea0
Compare
This allows tests to easily distinguish the effects of multiple formatters that could be applied during a single `jj fix` command, which is helpful for testing the feature for configuring multiple formatters on potentially overlapping filesets. Uppercase is a counterpart to lowercase. Append exposes the number of changes and their order of execution in the file content, which provides a terse way of writing test expectations.
…ilesets The high level changes include: - Reworking `fix_file_ids()` to loop over multiple candidate tools per file, piping file content between them. Only the final file content is written to the store, and content is no longer read for changed files that don't match any of the configured patterns. - New struct `ToolsConfig` to represent the parsed/validated configuration. - New function `get_tools_config()` to create a `ToolsConfig` from a `Config`. - New tests; the only old behavior that has changed is that we don't require `fix.tool-command` if `fix.tools` defines one or more tools. The general approach to validating the config is to fail early if anything is weird. Co-Authored-By: Josh Steadmon <[email protected]>
hooper
force-pushed
the
push-opqkpoomxpyq
branch
from
a5d6ea0 to
b403a7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md