Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli_util: short-prefixes for commit summary in transaction #4046

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

scott2000
Copy link
Contributor

I've run into change ID prefixes being 4-5 characters instead of the usual 1-2 characters in commands like jj duplicate and jj split fairly often, and it seems like this should resolve that. I tried to avoid creating a new IdPrefixContext unless changes have already been made in the transaction, since several commands call tx.format_commit_summary() before making any changes.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@scott2000 scott2000 force-pushed the commit-summary-short-prefixes branch from bcfa556 to cc9f81c Compare July 7, 2024 15:15
Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. For future reference, can you copy PR description to commit message?

cli/src/cli_util.rs Outdated Show resolved Hide resolved
scott2000 added 2 commits July 7, 2024 22:31
I've run into change ID prefixes being 4-5 characters instead of the
usual 1-2 characters in commands like `jj duplicate` and `jj split`
fairly often, and it seems like this should resolve that.
@scott2000 scott2000 force-pushed the commit-summary-short-prefixes branch from cc9f81c to e46ca26 Compare July 8, 2024 03:38
@scott2000 scott2000 merged commit a983abb into jj-vcs:main Jul 8, 2024
17 checks passed
@scott2000 scott2000 deleted the commit-summary-short-prefixes branch July 8, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants