Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: remove deprecated --allow-large-revsets flag at all #4018

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

yuja
Copy link
Collaborator

@yuja yuja commented Jul 3, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

It's been deprecated since v0.9.0 (2023-09-06). This patch doesn't add
changelog entry because the use of --allow-large-revsets was hard error.
Copy link
Collaborator

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Does this need a changelog entry? It was deprecated in 0.9 so that's the reference point if you want to mention it.

@yuja
Copy link
Collaborator Author

yuja commented Jul 3, 2024

It was a hard error, so I don't think changelog entry is needed.

@yuja yuja merged commit 455daa4 into jj-vcs:main Jul 3, 2024
17 checks passed
@yuja yuja deleted the push-yoplllmvwvyx branch July 3, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants