fake-editor: replace expectpath with dump-path #3995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
|
martinvonz
approved these changes
Jun 30, 2024
yuja
approved these changes
Jul 1, 2024
mlcui-corp
force-pushed
the
push-mxzxslstxpmq
branch
from
9267cc7 to
7096247
Compare
mlcui-corp
changed the title
|
Resolved comments - PTAL. |
yuja
approved these changes
Jul 1, 2024
martinvonz
approved these changes
Jul 1, 2024
martinvonz
reviewed
Jul 1, 2024
This allows us to assert the expected path in the test itself, rather than in the fake editor.
mlcui-corp
force-pushed
the
push-mxzxslstxpmq
branch
from
7096247 to
d811d04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to assert the expected path in the test itself, rather than in the fake editor.
(This will be used for when we de-UNC-ify invocations of the editor, see #3986 for more details.)
Checklist
If applicable:
CHANGELOG.md