clean up remainder of old branch API, with minor behavior changes in CLI output #3967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
reviewed
Jun 26, 2024
ilyagr
reviewed
Jun 26, 2024
Since we've split (local, remotes) branches to (locals, remotes { branches }),
.has_branch() API no longer makes much sense. Callers often need to check if
a remote branch is tracked.
It's used only in transaction descriptions, and I think singular form works at adjective position.
This will help inline view.remove_branch() in cmd_branch_forget(). I don't care much about owned (String, _) vs (&str, _), but we can't simplify the lifetime issue in find_forgettable_branches() anyway. So I made all callers pass cloned Arc<ReadonlyRepo> and borrow (name, target) pairs from there.
This API no longer makes sense, and we'll probably add some flags to forget only tracked remotes for example.
ilyagr
approved these changes
Jun 27, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md