Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Formalize our design docs process a bit. #3940

Merged
merged 2 commits into from
Jun 30, 2024
Merged

Conversation

PhilipMetzger
Copy link
Collaborator

@PhilipMetzger PhilipMetzger commented Jun 21, 2024

This adds the basic outline of when a Design Doc should be written. See the next
commit in the stack for the blueprint.

By adding this we hopefully can prevent unnecessary churn from new and longtime contributors,
when they want to add a major feature or rewrite a core part of Jujutsu. The text is written
as a guideline, not a rule.

@PhilipMetzger PhilipMetzger marked this pull request as ready for review June 27, 2024 18:25
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/design_docs.md Outdated Show resolved Hide resolved
docs/design_docs.md Outdated Show resolved Hide resolved
docs/contributing.md Outdated Show resolved Hide resolved
@PhilipMetzger PhilipMetzger force-pushed the push-kzzmwxztmyrv branch 2 times, most recently from 4f72113 to 09041cf Compare June 29, 2024 13:14
This adds the basic outline of _when_ a Design Doc should be written. See the next
commit in the stack for the blueprint. 

By adding this we hopefully can prevent unnecessary churn from new and longtime contributors, 
when they want to add a major feature or rewrite a core part of Jujutsu. The text is written
as a guideline, not a rule.
This should be the template for all new Design Docs, minor deviations aside.
Hopefully this makes the process a bit easier.
@PhilipMetzger PhilipMetzger merged commit 3b2197c into main Jun 30, 2024
29 checks passed
@PhilipMetzger PhilipMetzger deleted the push-kzzmwxztmyrv branch June 30, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants