cargo update
#3892
Closed
cargo update
#3892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
force-pushed
the
cargo-update
branch
3 times, most recently
from
6103c9c to
2b80de9
Compare
ilyagr
added a commit
to ilyagr/jj
that referenced
this pull request
Jun 15, 2024
Without this, `cargo deny` fails after a `cargo update` (https://github.com/martinvonz/jj/actions/runs/9531433728/job/26272377250?pr=3892 failed, but once it includes this commit, jj-vcs#3892 no longer has a `cargo deny` failure. The windows failure is unrelated))
ilyagr
added a commit
that referenced
this pull request
Jun 15, 2024
Without this, `cargo deny` fails after a `cargo update` (https://github.com/martinvonz/jj/actions/runs/9531433728/job/26272377250?pr=3892 failed, but once it includes this commit, #3892 no longer has a `cargo deny` failure. The windows failure is unrelated))
thoughtpolice
added a commit
that referenced
this pull request
Jun 19, 2024
Reissue of #3892 now that we have updated to `watchman_client` 0.9, which should fix this issue based on reading the source code.
4 tasks
thoughtpolice
added a commit
that referenced
this pull request
Jun 19, 2024
Reissue of #3892 now that we have updated to `watchman_client` 0.9, which should fix this issue based on reading the source code.
|
I filed an alternative to fix this in #3926 which went through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm mainly curious whether facebook/watchman#1217 was fixed.