Show paths of config files when configurations contain errors #3852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kintaro
force-pushed
the
push-pqxulluqzrmw
branch
from
9358bab to
874868e
Compare
martinvonz
reviewed
Jun 10, 2024
|
Sure. I'll add some later. |
Kintaro
force-pushed
the
push-pqxulluqzrmw
branch
from
874868e to
07a0142
Compare
|
I have updated it with a test case |
yuja
reviewed
Jun 10, 2024
This addresses issue jj-vcs#3317, where as discussed we want to show the paths to configuration files if they contain errors, to make it easier for the user to locate them.
Kintaro
force-pushed
the
push-pqxulluqzrmw
branch
from
07a0142 to
be74716
Compare
|
Addressed the nit and the error hinting. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #3317, where as discussed we want to show the paths to configuration files if they contain errors, to make it easier for the user to locate them.
Checklist
If applicable:
CHANGELOG.md