Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revset_graph: rename to graph and make generic over graph node type #3795

Merged
merged 1 commit into from
May 30, 2024

Conversation

bnjmnt4n
Copy link
Collaborator

As suggested in #3617 (comment), this PR attempts to land the commit renaming revset_graph to graph and making it generic to reduce the chances of further conflicts whilst I work on #3617.

Checklist

If applicable:

  • [NA] I have updated CHANGELOG.md
  • [NA] I have updated the documentation (README.md, docs/, demos/)
  • [NA] I have updated the config schema (cli/src/config-schema.json)
  • [NA] I have added tests to cover my changes

Copy link
Collaborator

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, as it is a pure NFC change.

@bnjmnt4n bnjmnt4n merged commit e0e1238 into main May 30, 2024
16 checks passed
@bnjmnt4n bnjmnt4n deleted the bnjmnt4n/push-324ffbe35f17355d7e9e4cc61e08312e branch May 30, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants