-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli git push: clearer user-facing messages #3765
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ilyagr
force-pushed
the
fwl-msg
branch
3 times, most recently
from
May 29, 2024 02:15
2b1a085
to
4ca75eb
Compare
ilyagr
commented
May 29, 2024
ilyagr
force-pushed
the
fwl-msg
branch
3 times, most recently
from
June 1, 2024 02:10
ceec404
to
aadc1ee
Compare
ilyagr
force-pushed
the
fwl-msg
branch
4 times, most recently
from
June 1, 2024 03:03
e216018
to
f2ed9ac
Compare
ilyagr
commented
Jun 1, 2024
yuja
reviewed
Jun 1, 2024
The refactor commit is now #3811. I can also include that commit here, but there seems to be no harm in reviewing it separately (and there is no time pressure on that PR). |
yuja
approved these changes
Jun 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you, Yuya! |
"Move forward" instead of "Move", "Move sideways" or "Move backward" instead of (now misleading) "Force...".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Move forward" instead of "Move", "Move sideways" or "Move backward"
instead of (now misleading) "Force...".
Previously discussed in #3522 (comment), and based on that PR (which contains 8 of the currently 9 commits).
Checklist
If applicable:
CHANGELOG.md