Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo update time, required for recent nightlies #3755

Merged
merged 1 commit into from
May 25, 2024

Conversation

ilyagr
Copy link
Contributor

@ilyagr ilyagr commented May 25, 2024

Without this, the time crate fails to compile on today's nightly. This problem occurred sometime between nightly-2024-05-11 and today's nightly.

Unfortunately, a full cargo update seems to break Watchman
on Windows:

https://github.com/martinvonz/jj/actions/runs/9233007115/job/25404996847?pr=3755

@ilyagr ilyagr marked this pull request as ready for review May 25, 2024 04:49
@ilyagr ilyagr enabled auto-merge (rebase) May 25, 2024 04:49
@ilyagr ilyagr marked this pull request as draft May 25, 2024 04:58
auto-merge was automatically disabled May 25, 2024 04:58

Pull request was converted to draft

Without this, the `time` crate fails to compile on today's
nightly.

Unfortunately, a full `cargo update` seems to break Watchman
on Windows:

https://github.com/martinvonz/jj/actions/runs/9233007115/job/25404996847?pr=3755
@ilyagr ilyagr changed the title cargo update, required for recent nightlies cargo update time, required for recent nightlies May 25, 2024
@ilyagr ilyagr marked this pull request as ready for review May 25, 2024 05:02
@ilyagr ilyagr enabled auto-merge (rebase) May 25, 2024 05:02
@ilyagr ilyagr merged commit b091334 into jj-vcs:main May 25, 2024
16 checks passed
@ilyagr ilyagr deleted the cargo-update branch May 25, 2024 05:25
@ilyagr
Copy link
Contributor Author

ilyagr commented May 25, 2024

I filed facebook/watchman#1217 for the problem with a full cargo update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants