revset: implement a "reachable()" expression #3691
Merged
+393
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torquestomp
force-pushed
the
dploch/subgraph
branch
from
04ec060 to
0d3e0bc
Compare
martinvonz
reviewed
May 15, 2024
torquestomp
force-pushed
the
dploch/subgraph
branch
2 times, most recently
from
8e07567 to
2e70c4e
Compare
torquestomp
changed the title
|
Per Discord chat I've renamed the function from 'subgraph' -> 'reachable' |
torquestomp
force-pushed
the
dploch/subgraph
branch
from
2e70c4e to
77840bb
Compare
torquestomp
changed the title
yuja
approved these changes
May 17, 2024
yuja
reviewed
May 17, 2024
Here's one (weak) vote for just |
martinvonz
reviewed
May 17, 2024
torquestomp
changed the title
torquestomp
force-pushed
the
dploch/subgraph
branch
from
77840bb to
ac0d7b2
Compare
This revset correctly implements "reachability" from a set of source commits following both parent and child edges as far as they can go within a domain set. This type of 'bfs' query is currently impossible to express with existing revset functions.
torquestomp
force-pushed
the
dploch/subgraph
branch
from
ac0d7b2 to
704d038
Compare
bnjmnt4n
reviewed
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't see a way to make this work without eager evaluation so I implemented a basic UnionFind algorithm for it.
Checklist
If applicable:
CHANGELOG.md