repo: move new commit ids into RewriteType enum
#3630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like I forgot this in some recent refactoring. I don't really see any harm in making the type public later. I might want to make `rebase_descendants()` not clear `parent_mapping` and instead provide a way of accessing it afterwards (removing the need for the `_return_map()` flavors). We'll see if that ends up happening. For now it can be private anyway.
`RewriteType::Rewritten` must have exactly one replacement. I think it's better to encode that in the type by attaching the value to the enum variant. I also renamed the type to just `Rewrite` since it now has attached data and `Type` sounds like a traditional data-free enum to me.
martinvonz
force-pushed
the
push-zzkmlqnvrtpo
branch
from
d265e23 to
d66d685
Compare
bnjmnt4n
approved these changes
May 6, 2024
thoughtpolice
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md