Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate errors from Commit::parents() and Commit::predecessors() #3625

Merged
merged 3 commits into from
May 13, 2024

Conversation

martinvonz
Copy link
Member

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

lib/src/commit.rs Outdated Show resolved Hide resolved
@martinvonz martinvonz force-pushed the push-qzuokysnzyqk branch 2 times, most recently from 5f05d94 to 2230910 Compare May 13, 2024 04:44
Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

cli/src/commands/rebase.rs Outdated Show resolved Hide resolved
@martinvonz martinvonz force-pushed the push-qzuokysnzyqk branch from 2230910 to d73fe9d Compare May 13, 2024 13:49
@martinvonz martinvonz enabled auto-merge (rebase) May 13, 2024 13:49
The function now returns an iterator over `Result`s, matching
`Operation::parents()`.

I updated callers to also propagate the error where it was trivial.
@martinvonz martinvonz force-pushed the push-qzuokysnzyqk branch from d73fe9d to ed6f65d Compare May 13, 2024 14:27
@martinvonz martinvonz merged commit ee9d327 into main May 13, 2024
16 checks passed
@martinvonz martinvonz deleted the push-qzuokysnzyqk branch May 13, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants