Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value of revsets.log to config docs #3619

Merged
merged 1 commit into from
May 5, 2024

Conversation

HybridEidolon
Copy link
Contributor

I wanted to have a reference point for the built-in revsets, but jj config get revsets.log doesn't turn anything up since it has special handling for the legacy config key
ui.default-revset. So I had to dig into the source code of jj to get it.

I think it might help others to be able to reason about revsets to have the log default shown in the settings documentation.

Checklist

If applicable:

  • I have updated the documentation (README.md, docs/, demos/)

I wanted to have a reference point for the built-in revsets,
but `jj config get revsets.log` doesn't turn anything up since
it has special handling for the legacy config key
`ui.default-revset`. So I had to dig into the source code of jj
to get it.

I think it might help others to be able to reason about revsets
to have the log default shown in the settings documentation.
Copy link
Contributor

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@martinvonz
Copy link
Member

for the legacy config key ui.default-revset

Feel free to delete that. According to the comment, it's from <0.8.0

@martinvonz martinvonz merged commit 3d898d0 into jj-vcs:main May 5, 2024
16 checks passed
@HybridEidolon HybridEidolon deleted the push-yrtmqlmoutrw branch May 13, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants