Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase: do not print out commit summaries of skipped commits #3603

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

bnjmnt4n
Copy link
Member

As discussed in #3396 (comment).

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@joyously
Copy link

Is there a global flag for verbose or quiet?

cli/src/commands/rebase.rs Outdated Show resolved Hide resolved
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-pmyylkyzlssu branch from 6c8b442 to 3c6a0a9 Compare April 30, 2024 15:29
@bnjmnt4n
Copy link
Member Author

Is there a global flag for verbose or quiet?

There's a global --quiet flag, but that suppresses all output, so it's not particularly relevant to this use case.

I originally added this behavior of printing skipped rebases, but I realized it's not that useful: typically I don't need to know what hasn't changed. What might be more useful is probably what has changed, but that's a separate change altogether.

cli/src/commands/rebase.rs Outdated Show resolved Hide resolved
cli/src/commands/rebase.rs Outdated Show resolved Hide resolved
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-pmyylkyzlssu branch from 3c6a0a9 to 64d3c30 Compare April 30, 2024 16:59
@bnjmnt4n bnjmnt4n merged commit f1f8454 into main Apr 30, 2024
16 checks passed
@bnjmnt4n bnjmnt4n deleted the bnjmnt4n/push-pmyylkyzlssu branch April 30, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants