templates: use "+" instead of "#" to denote immutable node in ascii graph

[yuja]

Maybe it's personal preference, but the hash sign looks bigger compared to the normal "o" nodes, and is slanted. This makes immutable commits stand out too much. I think "+" is closer to the diamond character used in the unicode template.

Checklist

If applicable:

• I have updated CHANGELOG.md
• I have updated the documentation (README.md, docs/, demos/)
• I have updated the config schema (cli/src/config-schema.json)
• I have added tests to cover my changes

[martinvonz]

@algmyr, @thoughtpolice

[algmyr]

I'm fine with whatever, this was discussed a bit in the discord. I personally like + as well, but there was the worry that it looks like part of the graph. That might not be much of an issue with the color being different though.

[algmyr]

I think as one of the (presumably few) users of the ascii theme, you have a big say in the symbols used. :)

[PhilipMetzger]

This makes sense as another user on the not yet modern Windows terminal.

[necauqua]

Pretty sure I was one of the people suggesting #, but I don't use ascii ¯\_(ツ)_/¯

+ is actually fine, yeah

[ilyagr]

(Non-blocking; I think I missed the Discord discussion)

Other possible symbols that come to my mind are % and =.

My mild preference would be %, if it's not too large for you. It kinda also looks like a diamond or a square (depending on the font, from a distance).

We might want to use + and - for diffing graphs for something like jj op diff. However, who knows if that idea ever materializes in that form and + sounds fine to me until then.

[yuja]

Other possible symbols that come to my mind are % and =.

To me, % doesn't look like a normal graph node symbol. Perhaps, I like + because it's symmetric in both horizontal and vertical directions. * was another option, but I felt + is easier to distinguish from o.