Use CommitIteratorExt to replace .map(|c| c.id().clone())
#3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emesterhazy
force-pushed
the
push-nzrxlwovyuvp
branch
2 times, most recently
from
11b4eaa to
e0f6360
Compare
martinvonz
approved these changes
Apr 19, 2024
This replaces `.map(|c| c.id().clone())` with `.ids().cloned()` to use nicer syntax for getting `CommitId`s from an iterator of commits using the `CommitIteratorExt` trait. In one case we can actually call `.parent_ids()` directly. I also pluralized a variable to make it clearer that it's a vec of IDs and not a single ID.
emesterhazy
force-pushed
the
push-nzrxlwovyuvp
branch
from
e0f6360 to
44a18d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
.map(|c| c.id().clone())with.ids().cloned().This is a minor cleanup to use nicer syntax for getting
CommitIds from an iterator of commits using theCommitIteratorExttrait.