Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extensions of the SymbolResolver in revset evaluation #3527

Merged
merged 5 commits into from
Apr 26, 2024

Conversation

torquestomp
Copy link
Contributor

This also sets up some container types for other types of revset extensions, plumbed through CliRunner.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@torquestomp torquestomp force-pushed the dploch/symbol-ext branch 2 times, most recently from 6c874a2 to c2f0518 Compare April 17, 2024 20:56
lib/src/revset.rs Outdated Show resolved Hide resolved
lib/src/revset.rs Outdated Show resolved Hide resolved
lib/src/revset.rs Outdated Show resolved Hide resolved
cli/src/revset_util.rs Show resolved Hide resolved
@torquestomp torquestomp force-pushed the dploch/symbol-ext branch 3 times, most recently from fcccc85 to f595eab Compare April 22, 2024 19:09
@torquestomp torquestomp force-pushed the dploch/symbol-ext branch 3 times, most recently from 89d87f8 to dd2b9ae Compare April 25, 2024 19:01
Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks!

lib/src/revset.rs Outdated Show resolved Hide resolved
lib/src/revset.rs Outdated Show resolved Hide resolved
lib/src/revset.rs Outdated Show resolved Hide resolved
lib/src/revset.rs Show resolved Hide resolved
lib/src/revset.rs Show resolved Hide resolved
lib/src/id_prefix.rs Outdated Show resolved Hide resolved
lib/src/revset.rs Show resolved Hide resolved
lib/src/revset.rs Outdated Show resolved Hide resolved
lib/src/revset.rs Outdated Show resolved Hide resolved
@torquestomp torquestomp enabled auto-merge (rebase) April 26, 2024 14:47
@torquestomp torquestomp merged commit 586ab1f into main Apr 26, 2024
16 checks passed
@torquestomp torquestomp deleted the dploch/symbol-ext branch April 26, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants