-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support extensions of the SymbolResolver in revset evaluation #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torquestomp
force-pushed
the
dploch/symbol-ext
branch
2 times, most recently
from
April 17, 2024 20:56
6c874a2
to
c2f0518
Compare
yuja
reviewed
Apr 18, 2024
torquestomp
force-pushed
the
dploch/symbol-ext
branch
3 times, most recently
from
April 22, 2024 19:09
fcccc85
to
f595eab
Compare
torquestomp
force-pushed
the
dploch/symbol-ext
branch
3 times, most recently
from
April 25, 2024 19:01
89d87f8
to
dd2b9ae
Compare
yuja
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, thanks!
torquestomp
force-pushed
the
dploch/symbol-ext
branch
from
April 26, 2024 14:46
dd2b9ae
to
97619cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also sets up some container types for other types of revset extensions, plumbed through CliRunner.
Checklist
If applicable:
CHANGELOG.md