matchers: refactor RepoPathTree (prep for glob matcher) #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm going to extract generic map from RepoPathTree, and .get_visit_sets() will be inlined into FilesMatcher/PrefixMatcher. These removed tests should be covered by the corresponding matcher tests.
Perhaps, I didn't do that because it's important to initialize is_dir/file to false. Since I'm going to extract a generic map-like API, and is_dir/file will be an enum, this won't be a problem.
…ir flag The is_dir flag will be removed soon. Since FilesMatcher doesn't set is_dir flag explicitly, is_dir is equivalent to !entries.is_empty(). OTOH, PrefixMatcher always sets is_dir, so all tree nodes are directories.
This prepares for adding glob matcher, which will be backed by RepoPathTree<Vec<glob::Pattern>>. FilesNodeKind/PrefixNodeKind are basically boolean types, but implemented as enums for better code readability.
torquestomp
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md