Make MutableRepo::parent_mapping private by moving code onto the type
#3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I rewrote `old_target` and `new_target` to more accurately represent the change; the old target should be a normal (singleton) ref.
martinvonz
force-pushed
the
push-xqwoyputpukr
branch
from
f8b5f6f to
0314b1b
Compare
With this change, `update_all_references()` only uses `self` to get to `mut_repo`. I'll move the function onto `MutableRepo` next.
I think the recent refactorings (especially 9c382fd) make it pretty clear that `DescendantRebaser` will not attempt to rebase the same commit twice, so I think we can remove the assertions. This removes some of the places where `DescendantRebaser` reaches into `MutableRepo`'s internals.
martinvonz
force-pushed
the
push-xqwoyputpukr
branch
from
0314b1b to
1aa50ff
Compare
The functions now depend only on `MutableRepo`, so I think they belong on that type. This gets us closer to being able to make `parent_mapping` private again.
This lets us make `parent_mapping` private again.
martinvonz
force-pushed
the
push-xqwoyputpukr
branch
from
1aa50ff to
9961bab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md