cli: migrate "cat" to matcher API #3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emesterhazy
reviewed
Apr 14, 2024
yuja
force-pushed
the
push-zowltknqtmzo
branch
4 times, most recently
from
fba3df5 to
eeaa7af
Compare
emesterhazy
approved these changes
Apr 14, 2024
Prepares for migrating to the matcher API. "Path exists but is not a file" error is turned into a warning because the loop shouldn't terminate there. "No such path" error message is also updated for consistency.
This is the last non-debug command that doesn't support file patterns. It wouldn't make much sense to "cat" multiple files (despite the command name), but doing that should be harmless.
yuja
changed the title
yuja
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md