Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli_util: support multiple extensions consistently #3491

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

torquestomp
Copy link
Contributor

If we ever implement some sort of ABI for dynamic extension loading, we'll need these underlying APIs to support multiple extensions, so we might as well do that first.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

.vscode/settings.json Outdated Show resolved Hide resolved
cli/src/cli_util.rs Outdated Show resolved Hide resolved
cli/src/cli_util.rs Outdated Show resolved Hide resolved
lib/src/repo.rs Outdated Show resolved Hide resolved
If we ever implement some sort of ABI for dynamic extension loading, we'll need these underlying APIs to support multiple extensions, so we might as well do that first.
@torquestomp torquestomp force-pushed the dploch/ext-multiple branch from 3341bff to 0bad488 Compare April 12, 2024 17:59
@torquestomp torquestomp enabled auto-merge (rebase) April 12, 2024 17:59
@torquestomp torquestomp merged commit 57a5d7d into main Apr 12, 2024
16 checks passed
@torquestomp torquestomp deleted the dploch/ext-multiple branch April 12, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants