Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Watchman config better, new jj debug watchman status command #3484

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

ilyagr
Copy link
Contributor

@ilyagr ilyagr commented Apr 11, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

I was wondering how to disable the watchman in a repo if it's enabled in
the user config.
@ilyagr ilyagr marked this pull request as ready for review April 11, 2024 05:35
@ilyagr ilyagr marked this pull request as draft April 11, 2024 06:06
@ilyagr ilyagr changed the title config docs: document valid fsmonitor values Document Watchman config better, new jj debug watchman status command Apr 11, 2024
@ilyagr ilyagr marked this pull request as ready for review April 11, 2024 06:10
This command checks not only whether Watchman works, but also whether
it's enabled in the config. Also, the output is easier to understand
than that of the other `jj debug watchman` commands.

It would be nice if `jj debug watchman` called `jj debug watchman
status`, but it's not trivial in `clap` to have a default subcommand.
@ilyagr ilyagr merged commit 8fa256e into jj-vcs:main Apr 11, 2024
16 checks passed
@ilyagr ilyagr deleted the fsmonitornone branch April 11, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants