Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add ui.always-allow-large-revsets option #3458

Merged
merged 1 commit into from
Apr 4, 2024
Merged

cli: add ui.always-allow-large-revsets option #3458

merged 1 commit into from
Apr 4, 2024

Conversation

thoughtpolice
Copy link
Contributor

This lets users use "large" revsets in commands such as jj rebase, without needing the all: modifier.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@thoughtpolice thoughtpolice force-pushed the aseipp/push-nlqpwnkqmrvw branch from 6d5d00a to 2ef417f Compare April 4, 2024 21:41
noahmayr
noahmayr reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@noahmayr noahmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the term "large revsets", apart from that lgtm

cli/src/config-schema.json Outdated Show resolved Hide resolved
martinvonz
martinvonz reviewed Apr 4, 2024
View reviewed changes
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not sure "large" is the best word but I'm not sure if "non-singleton" is good either. While most programmers know what "singleton" means, I'm a bit worried it's unnecessarily technical.

cli/tests/test_rebase_command.rs Outdated Show resolved Hide resolved
cli/src/config/misc.toml Outdated Show resolved Hide resolved
cli/tests/test_rebase_command.rs Outdated Show resolved Hide resolved
cli/tests/test_rebase_command.rs Outdated Show resolved Hide resolved
@thoughtpolice thoughtpolice force-pushed the aseipp/push-nlqpwnkqmrvw branch 2 times, most recently from fbc57c7 to 2f8a456 Compare April 4, 2024 22:53
@thoughtpolice thoughtpolice changed the title cli: add revsets.always-allow-large-revsets option cli: add ui.always-allow-large-revsets option Apr 4, 2024
@thoughtpolice
cli: add ui.always-allow-large-revsets option
3e06575 
This lets users use "large" revsets in commands such as `jj rebase`, without
needing the `all:` modifier.

Signed-off-by: Austin Seipp <[email protected]>
Change-Id: Ica80927324f3d634413d3cc79fbc73057ccefd8a
@thoughtpolice thoughtpolice force-pushed the aseipp/push-nlqpwnkqmrvw branch from 2f8a456 to 3e06575 Compare April 4, 2024 22:54
@thoughtpolice thoughtpolice merged commit db14f33 into main Apr 4, 2024
16 checks passed
@thoughtpolice thoughtpolice deleted the aseipp/push-nlqpwnkqmrvw branch April 4, 2024 23:38
@ilyagr ilyagr mentioned this pull request Apr 11, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahmayr noahmayr noahmayr approved these changes

@martinvonz martinvonz martinvonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thoughtpolice @martinvonz @noahmayr