Make check_rewritable take an iterator of &CommitId instead of &Commit #3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. check_rewritable does not need to revwalk the given commits at all (the revwalk is from the repository's information about which commits are immutable) so it makes sense that the minimum information needed is only the ID. Also, RevsetIteratorExt is already a thing so CommitIteratorExt is fine. |
jonathantanmy
approved these changes
Apr 3, 2024
yuja
approved these changes
Apr 4, 2024
emesterhazy
force-pushed
the
push-xmkqtumzqspt
branch
2 times, most recently
from
fa59510 to
8de7a17
Compare
This function doesn't actually need commits, it only needs their IDs. In some contexts we may only have commit IDs, so there's no need to require an iterator of Commits. This commit also adds a `CommitIteratorExt` that makes it easy to convert an iterator of `&Commit` to an iterator of `&CommitId`.
emesterhazy
force-pushed
the
push-xmkqtumzqspt
branch
from
8de7a17 to
d1033bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function doesn't actually need commits, it only needs their IDs. In some contexts we may only have commit IDs, so there's no need to require an iterator of Commits.
This commit also adds a
CommitIteratorExtthat makes it easy to convert an iterator of&Committo an iterator of&CommitId.