Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add op waypoint command #3433

Closed
wants to merge 1 commit into from
Closed

Conversation

noahmayr
Copy link
Contributor

@noahmayr noahmayr commented Apr 3, 2024

resolves #3428

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@noahmayr noahmayr force-pushed the push-mzvpprtzrqwz branch from a1e0a26 to 8fd11ac Compare April 3, 2024 15:23
@noahmayr noahmayr force-pushed the push-mzvpprtzrqwz branch from 8fd11ac to 87297b3 Compare April 3, 2024 17:16
@yuja
Copy link
Contributor

yuja commented Apr 4, 2024

Maybe this would be pointed out on Discord, but I think "waypoint" should be a ref-like object (i.e. pointer to an operation, not metadata of an operation.) That will probably simplify lookup implementation.

I'm not sure which model is preferable, though:

  • op_head -> operation, waypoint -> operation
  • op_head -> {waypoints, operation}

@noahmayr noahmayr mentioned this pull request Apr 4, 2024
4 tasks
@noahmayr
Copy link
Contributor Author

noahmayr commented Apr 4, 2024

closing in favor of #3455
(recreated the pr from a branch on the main repo so it's easier to check out and test if necessary)

@noahmayr noahmayr closed this Apr 4, 2024
@noahmayr noahmayr deleted the push-mzvpprtzrqwz branch April 4, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: op log waypoints
2 participants