Fix a few minor issues with the jj prev tests #3430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuja
reviewed
Apr 3, 2024
emesterhazy
force-pushed
the
push-qwxwsrzwqtxy
branch
2 times, most recently
from
ff6572d to
2e6ca9e
Compare
yuja
reviewed
Apr 4, 2024
emesterhazy
force-pushed
the
push-qwxwsrzwqtxy
branch
from
2e6ca9e to
005f803
Compare
emesterhazy
changed the title
emesterhazy
force-pushed
the
push-qwxwsrzwqtxy
branch
2 times, most recently
from
9696d67 to
73711de
Compare
PhilipMetzger
requested changes
Apr 4, 2024
emesterhazy
force-pushed
the
push-qwxwsrzwqtxy
branch
2 times, most recently
from
9f4db66 to
9fbfa8b
Compare
Done. I deleted everything that mentioned discardable commits. |
emesterhazy
force-pushed
the
push-qwxwsrzwqtxy
branch
from
9fbfa8b to
0f069ac
Compare
|
Is there anything else we should change or is this ready now? |
emesterhazy
force-pushed
the
push-qwxwsrzwqtxy
branch
from
0f069ac to
e959102
Compare
yuja
reviewed
Apr 8, 2024
This commit adds commit graphs to most of the tests for `jj prev` to make it clearer where `@` points before and after `prev` is run. In addition, there were a couple of tests where the comments suggested the test meant to have `@` pointing to a specific commit, but it actually pointed to an empty child of that commit. This sort of issue also exists in `test_prev_editing`. The test is supposed to check that `--edit` is implied if you run `jj prev` on an interior commit, but it actually caused a new empty commit to be created since `@` was sitting on a tip commit.
emesterhazy
force-pushed
the
push-qwxwsrzwqtxy
branch
from
e959102 to
bac9891
Compare
PhilipMetzger
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds commit graphs to most of the tests for
jj prevto make itclearer where
@points before and afterprevis run.In addition, there were a couple of tests where the comments suggested the test
meant to have
@pointing to a specific commit, but it actually pointed to anempty child of that commit.
This sort of issue also exists in
test_prev_editing. The test is supposed tocheck that
--editis implied if you runjj prevon an interior commit, butit actually caused a new empty commit to be created since
@was sitting on atip commit.