Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: support filtering by paths in status #3429

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

solson
Copy link
Member

@solson solson commented Apr 2, 2024

I often work in multiple subtrees of a monorepo at once, and want to list modified files only in the current subtree, as supported by git status . or hg status ..

Example (applied to this change itself):

image

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@solson solson requested a review from martinvonz April 2, 2024 22:01
@martinvonz
Copy link
Member

There's no need to assign a reviewer. Someone usually picks it up anyway. We were actually just talking about having a rotation of googlers focus on reviews :)

@martinvonz martinvonz removed their request for review April 2, 2024 22:03
@solson
Copy link
Member Author

solson commented Apr 2, 2024

Ack, I was following the GitHub UI's recommendation but not sure of the project's actual policy. ^^

cli/src/commands/status.rs Show resolved Hide resolved
cli/src/commands/status.rs Outdated Show resolved Hide resolved
@solson solson force-pushed the solson/status-filter branch 2 times, most recently from 02c9843 to ae25bc8 Compare April 3, 2024 19:59
cli/src/commands/resolve.rs Outdated Show resolved Hide resolved
@solson solson force-pushed the solson/status-filter branch 2 times, most recently from b26b466 to ed935f2 Compare April 4, 2024 18:55
Copy link
Contributor

@noahmayr noahmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CHANGELOG.md Outdated Show resolved Hide resolved
@solson solson force-pushed the solson/status-filter branch from ed935f2 to c721d48 Compare April 5, 2024 17:10
@solson solson merged commit e22370c into main Apr 5, 2024
16 checks passed
@solson solson deleted the solson/status-filter branch April 5, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants