Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revset: parse "all:" prefix rule by pest #3422

Merged
merged 2 commits into from
Apr 2, 2024
Merged

revset: parse "all:" prefix rule by pest #3422

merged 2 commits into from
Apr 2, 2024

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Apr 2, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

yuja added 2 commits April 2, 2024 15:18
@yuja
revset: add ParseState constructor
04c0735
@yuja
revset: parse "all:" prefix rule by pest
af75ee0 
I had to use negative lookahead !":" because we still support a dummy ":"
operator to provide a suggestion.
martinvonz
martinvonz approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

PhilipMetzger
PhilipMetzger approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the thing I implied in #3036 (review)

@yuja yuja merged commit bb87fac into jj-vcs:main Apr 2, 2024
16 checks passed
@yuja yuja deleted the push-wvsuunrwnsqr branch April 2, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahmayr noahmayr noahmayr left review comments

@PhilipMetzger PhilipMetzger PhilipMetzger approved these changes

@martinvonz martinvonz martinvonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuja @martinvonz @noahmayr @PhilipMetzger