Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revset: add working_copies() function #3418

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

ckoehler
Copy link
Contributor

@ckoehler ckoehler commented Apr 1, 2024

It includes the working copy commit of every workspace of the repo.

Implements #3384

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@ckoehler ckoehler force-pushed the push-pnmlxrmnnkzv branch 2 times, most recently from 308d28d to e5b0a40 Compare April 1, 2024 19:57
@ckoehler
Copy link
Contributor Author

ckoehler commented Apr 1, 2024

Not sure how to test this, would appreciate some pointers. Is there an easy way to create a repo with two workspaces, create some commits, and then compare those to the output of working_copies()? Sounds involved.

Nevermind, this looks straightforward: https://github.com/martinvonz/jj/blob/main/lib/tests/test_revset.rs#L332

@ckoehler ckoehler force-pushed the push-pnmlxrmnnkzv branch from e5b0a40 to 96b839a Compare April 1, 2024 20:03
@martinvonz
Copy link
Member

Not sure how to test this, would appreciate some pointers. Is there an easy way to create a repo with two workspaces, create some commits, and then compare those to the output of working_copies()? Sounds involved.

Maybe it can be done similar to how we do it for @ here: https://github.com/martinvonz/jj/blob/7b3f8e8cb6cc33e5f183052822e081160bba564f/lib/tests/test_revset.rs#L331-L372

@ckoehler ckoehler force-pushed the push-pnmlxrmnnkzv branch 3 times, most recently from af22478 to ef36d55 Compare April 1, 2024 20:33
lib/src/revset.rs Outdated Show resolved Hide resolved
lib/src/revset.rs Outdated Show resolved Hide resolved
@ckoehler ckoehler force-pushed the push-pnmlxrmnnkzv branch from ef36d55 to 1ae482a Compare April 2, 2024 01:20
It includes the working copy commit of every workspace of the repo.

Implements jj-vcs#3384
@ckoehler ckoehler force-pushed the push-pnmlxrmnnkzv branch from 1ae482a to 55e4a93 Compare April 2, 2024 01:23
Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

@ckoehler ckoehler merged commit 7bde6dd into jj-vcs:main Apr 2, 2024
16 checks passed
@ckoehler ckoehler deleted the push-pnmlxrmnnkzv branch April 2, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants