cli: refactor single/default_single revset evaluation helpers #3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function isn't small, so let's split up into two parts. The extracted function is the part which depends on the commit summary template.
…l_prefix() I'm going to reorganize "single"/"default_single" revset functions in a way that resolve_single_rev_with_hint_about_all_prefix() is inlined. evaluate_revset_to_single_commit() could be a private method of WorkspaceCommandHelper, but I want to minimize the code that has to be hosted there.
…nd helper resolve_revset_default_single() will be inlined instead. Since "default_single" evaluation can return multiple revisions, the CLI interface usually accepts multiple arguments. This suggests that there would be no external callers of the singular resolve_revset_default_single().
…refix() Yet another step towards inlining resolve_revset_default_single(). I'll reimplement parse_revset_with_all_prefix() later to be pest-based.
Since "all:" implies that the user doesn't care about the order of the revisions within that argument, it should be okay if two "all:" sets overlapped.
There's only one caller, and the implementation is straightforward.
martinvonz
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md