sparse: parse/print workspace-relative paths, extract more subcommands #3388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per comment in jj-vcs#3379 (review) Though cwd-relative path might be useful for --remove, I don't think that's the common use case. The new behavior is consistent with --edit.
…lock I assumed locked_wc.sparse_patterns() is cheap operation. If it isn't, a locked_ws/wc should be passed to the callback instead.
Even though --edit can be combined with --add/--remove/--clear/--reset, I don't think it's practically useful.
Since "set --add" removes duplicated patterns, it makes sense for "edit" to do the same thing.
Since --reset conflicts with the other flags, "set --reset" seems odd.
martinvonz
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md