Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: colorize commits summary embedded in single revset resolution hint #3372

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Mar 26, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

yuja added 2 commits March 27, 2024 00:16
A formatted error is not a string containing ANSI escape sequences because 1.
the output may be differently colored inside "hint", 2. the caller might not
be accessible to ui.new_formatter().
I think a colorized commit summary is easier to follow.
@yuja yuja force-pushed the push-mpuxpqunvvll branch from 2d4cd52 to ba7afe9 Compare March 26, 2024 15:18
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds helpful. Thanks!

@yuja yuja merged commit 423a2a5 into jj-vcs:main Mar 27, 2024
16 checks passed
@yuja yuja deleted the push-mpuxpqunvvll branch March 27, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants