templater: remove unused context parameter from Template<C>
#3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type parameter 'C' will be removed from the Template trait, making it represent a printable type or compiled template. TemplateRenderer now holds Box<dyn _> template because it's unlikely that the inner template type can be statically determined.
IntoTemplate will be cleaned up later. Perhaps, the lifetime parameter can be removed at this point, but I'm planning to remove the IntoTemplate trait at all.
…= ..> They are similar in a way that both of them can represent dynamic/static evaluation, but their behaviors are different in error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md