Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templater: turn logical && and || into short-circuiting operators #3354

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Mar 24, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

Since the context (or self) property is no longer passed by argument, it's easy
to implement short-circuiting behavior.
@yuja yuja merged commit 96e0bc0 into jj-vcs:main Mar 25, 2024
16 checks passed
@yuja yuja deleted the push-rxrukvsumrkn branch March 25, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants