cli: allow colors in form '#rrggbb' #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
tomafro
force-pushed
the
push-lsxlqsxwrwvl
branch
from
84bfba4 to
8caa227
Compare
yuja
reviewed
Mar 16, 2024
tomafro
force-pushed
the
push-lsxlqsxwrwvl
branch
from
8caa227 to
77276c6
Compare
tomafro
changed the title
tomafro
force-pushed
the
push-lsxlqsxwrwvl
branch
3 times, most recently
from
05f0212 to
e0382cc
Compare
tomafro
commented
Mar 17, 2024
yuja
approved these changes
Mar 17, 2024
yuja
reviewed
Mar 17, 2024
tomafro
force-pushed
the
push-lsxlqsxwrwvl
branch
3 times, most recently
from
8eaf9fb to
3aa5610
Compare
Changes the formatter to accept not only existing color names (such as "red" or "green") but also those in the form #rrggbb, where rr, gg, and bb are two-digit hexadecimal numbers. This allows much finer control over colors used.
tomafro
force-pushed
the
push-lsxlqsxwrwvl
branch
from
3aa5610 to
9c174ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this change partly to scratch a very minor personal itch, but mainly as a first step to get my head around the codebase, build process, etc. TBH I was surprised how easy it was to support this (being English the hardest part was writing color vs colour!). Given how little complexity it adds to the code, I'd hope it would be considered.
That said, all new features are overhead, and I will not be offended if this is unwanted. I've enjoyed getting it working and learnt a lot, which was my main goal.
Thanks everyone for all the work on jujutsu. I'm really enjoying using it.
Checklist
If applicable:
CHANGELOG.md