revset: detach index from internal evaluation tree #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This serves the same role as templater::Literal. I'm going to add basic RevWalk adapters so that the revset evaluation tree can be constructed without capturing the index. EagerRevWalk will help to write tests for these adapters.
This helps to migrate union/intersection/difference iterators to RevWalk.
FilterRevset will be built on top.
This is the step towards removing &CompositeIndex references from the revset evaluation tree. The filter input is changed from &IndexEntry to IndexPosition to simplify the lifetime thingy. We might want to pass around CommitId or Commit object once it's loaded, but that can be implemented later. I don't see significant performance difference in revset benches.
Now all source/sink nodes produce/consume IndexPosition, so it doesn't make sense to keep InternalRevset::entries().
Perhaps, union/intersection/difference combinators can be moved to the rev_walk module, but let's think about that later.
martinvonz
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md