index: turn CompositeIndex into transparent reference type #3269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps to migrate CompositeIndex<'_> wrapper to &CompositeIndex. If the wrapped reference had a lifetimed field, it couldn't be represented as a trivial reference type.
This helps to eliminate higher-ranked trait bounds from RevWalkRevset and RevWalk combinators to be added. Since &CompositeIndex is now a real reference, it can be passed to functions as index: &T.
…iteIndex Just a minor code cleanup. We still need Index for &CompositeIndex because the type is unsized, and unsized type cannot be converted to another dyn reference.
martinvonz
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md