index: allow to detach CompositeIndex<'_> from RevWalk
#3266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the RevWalkIndex API. It would probably add fractional msecs of overhead per next() call, but I don't see significant difference in revset benches.
This eliminates lifetimed fields from RevWalk objects, and the RevWalk object will be embedded directly in RevWalkRevset. This patch adds two separate iterator adapters. They are identical at this point, but I'm going to add detach/reattach methods only to the borrowed version. I'm also planning to change CompositeIndex<'_> to &CompositeIndex to get around higher-ranked trait bound restrictions.
Just for consistency. Descendants are always evaluated eagerly, so this change isn't strictly needed.
"for<'index> RevWalk<CompositeIndex<'index>, .." works as of now, but it won't be composed well. So I'll turn CompositeIndex<'_> into &CompositeIndex in the next batch, and remove "for<'index>".
martinvonz
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md