index: migrate RevWalk constructors to builder API #3264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm planning to add RevWalk trait, and this patch frees up the name. It seems also good for consistency as we have RevWalkDescendants*.
The current RevWalk constructors insert intermediate items to BinaryHeap and convert them as needed. This is redundant, and I'm going to add another parameter that should be applied to the queue first. That's why I decided to factor out a builder type. I considered adding a few set of factory functions that receive all parameters, but they looked messy because most of the parameters are of [IndexPosition] type. This patch also adds must_use to the builder and its return types, which are all iterator-like.
It doesn't make sense to build BinaryHeap with intermediate type, and I'm going to reimplement take_until_roots() in a way that the queue drops uninteresting items.
I'm going to make CompositeIndex<'_> detachable from the RevWalk, and "F: Fn(CompositeIndex) -> Box<dyn Iterator<..>>" of RevWalkRevset<F> will be replaced with "W: RevWalk<CompositeIndex>". This will simplify the code structure, but also means that we can no longer apply .take_while() here and convert it back to RevWalk. Fortunately, ancestors_until_roots() is the only function I need to reimplement.
Since the return type is no longer "impl Iterator<..>", there isn't lifetime issue anymore.
martinvonz
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md