Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration options for node symbols in the graphs #3263

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Add configuration options for node symbols in the graphs #3263

merged 1 commit into from
Mar 9, 2024

Conversation

algmyr
Copy link
Contributor

@algmyr algmyr commented Mar 9, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@algmyr
Copy link
Contributor Author

algmyr commented Mar 9, 2024

Not sure whether to use a tuple or create a struct for the symbols. I guess there is always the option to switch as more possible symbols are added.

martinvonz
martinvonz approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I would like to see this templated eventually, but that can come later.

@algmyr algmyr merged commit 099f06b into jj-vcs:main Mar 9, 2024
16 checks passed
@algmyr algmyr deleted the push-pwxtlmswxxyt branch March 9, 2024 20:17
@martinvonz martinvonz mentioned this pull request Mar 9, 2024
Closed
@thoughtpolice thoughtpolice mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz approved these changes

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@algmyr @thoughtpolice @martinvonz