Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render synthetic nodes in jj log by default #3261

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Render synthetic nodes in jj log by default #3261

merged 2 commits into from
Mar 11, 2024

Conversation

martinvonz
Copy link
Member

@martinvonz martinvonz commented Mar 8, 2024 •
edited
Loading

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@thoughtpolice
Copy link
Member

Do we want to do this while DOTTED CIRCLE still renders so badly in some terminals? I suspect we'll get complaints immediately. But I guess, probably any choice might end up the same way, because fonts and terminals and unicode are all strange beasts...

@martinvonz
Copy link
Member Author

Do we want to do this while DOTTED CIRCLE still renders so badly in some terminals? I suspect we'll get complaints immediately. But I guess, probably any choice might end up the same way, because fonts and terminals and unicode are all strange beasts...

Good question. I've asked for clarification in #3238 (reply in thread)

@martinvonz
Copy link
Member Author

martinvonz commented Mar 9, 2024 •
edited
Loading

Turns out the harpoons don't work any better (thanks for checking, @amiryal) :( So what do you think, @thoughtpolice? I'm leaning towards enabling the synthetic nodes despite the ugly rendering in some terminals.

yuja
yuja approved these changes Mar 11, 2024
View reviewed changes
cli/src/commands/log.rs Outdated Show resolved Hide resolved
@martinvonz
Copy link
Member Author

Ping, @thoughtpolice. If I don't hear from you, I'll merge this tomorrow.

@martinvonz
log: add some documentation
0070d88 
The `jj log` command had basically no documentation. Let's at least
start adding some.
@martinvonz
log: enable synthetic elided nodes by default
eabbef6 
We're early in the release cycle, so let's enable this feature and
test it for a while before the next release.
@martinvonz martinvonz merged commit e579bba into main Mar 11, 2024
16 checks passed
@martinvonz martinvonz deleted the push-ruvpmunvkrxy branch March 11, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuja yuja yuja approved these changes

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinvonz @thoughtpolice @yuja