Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: move jj amend/unamend aliases to config #3252

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Conversation

martinvonz
Copy link
Member

The amend/unamend aliases exist for smoothen onboarding for Git/Mercurial users; I don't think we should recommend that users use them, so I think it's fine if users override them as they like. Therefore, I think they belong in the config.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

The `amend/unamend` aliases exist for smoothen onboarding for
Git/Mercurial users; I don't think we should recommend that users use
them, so I think it's fine if users override them as they
like. Therefore, I think they belong in the config.
@martinvonz martinvonz merged commit 6d78d92 into main Mar 10, 2024
16 checks passed
@martinvonz martinvonz deleted the push-npmprnuznzqw branch March 10, 2024 06:43
cenviity added a commit to cenviity/jj that referenced this pull request Jul 18, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend users use `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Jul 18, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend users use `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Jul 19, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend users use `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Jul 19, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Jul 19, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Jul 19, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Jul 19, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Jul 20, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Jul 22, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Jul 22, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Jul 25, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Jul 25, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Aug 6, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Aug 6, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Aug 7, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Aug 8, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Aug 9, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Aug 14, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Aug 14, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Aug 15, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Aug 16, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Aug 19, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Aug 20, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Oct 14, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Oct 14, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Oct 15, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Oct 15, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Oct 15, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Oct 16, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Oct 18, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Oct 18, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Oct 21, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Oct 21, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Oct 22, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Oct 23, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Oct 23, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Oct 23, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Oct 23, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Oct 24, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Oct 28, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Nov 1, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Nov 2, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Nov 3, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Nov 7, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Nov 7, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Nov 12, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Nov 15, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Nov 17, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Nov 29, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Nov 29, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Dec 2, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Dec 4, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
cenviity added a commit to cenviity/jj that referenced this pull request Dec 5, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This
is the only remaining occurrence of it in the docs. We should recommend using `jj
squash` directly instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants