-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: move jj amend/unamend
aliases to config
#3252
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `amend/unamend` aliases exist for smoothen onboarding for Git/Mercurial users; I don't think we should recommend that users use them, so I think it's fine if users override them as they like. Therefore, I think they belong in the config.
martinvonz
force-pushed
the
push-npmprnuznzqw
branch
from
March 7, 2024 23:37
40b8c77
to
472dd0a
Compare
4 tasks
thoughtpolice
approved these changes
Mar 8, 2024
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Jul 18, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend users use `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Jul 18, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend users use `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Jul 19, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend users use `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Jul 19, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Jul 19, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Jul 19, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Jul 19, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Jul 20, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Jul 22, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Jul 22, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Jul 25, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Jul 25, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Aug 6, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Aug 6, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Aug 7, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Aug 8, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Aug 9, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Aug 14, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Aug 14, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Aug 15, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Aug 16, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Aug 19, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Aug 20, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Oct 14, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Oct 14, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Oct 15, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Oct 15, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Oct 15, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Oct 16, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Oct 18, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Oct 18, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Oct 21, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Oct 21, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Oct 22, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Oct 23, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Oct 23, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Oct 23, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Oct 23, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Oct 24, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Oct 28, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Nov 1, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Nov 2, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Nov 3, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Nov 7, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Nov 7, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Nov 12, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Nov 15, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Nov 17, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Nov 29, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Nov 29, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Dec 2, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Dec 4, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
cenviity
added a commit
to cenviity/jj
that referenced
this pull request
Dec 5, 2024
`jj amend` is discouraged and no longer a visible alias of `jj squash` since jj-vcs#3252. This is the only remaining occurrence of it in the docs. We should recommend using `jj squash` directly instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
amend/unamend
aliases exist for smoothen onboarding for Git/Mercurial users; I don't think we should recommend that users use them, so I think it's fine if users override them as they like. Therefore, I think they belong in the config.Checklist
If applicable:
CHANGELOG.md