-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: move jj co
alias to config file, so it can be overridden
#3242
Conversation
This way users can override `jj co` to mean `jj new` if they want to get rid of the warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@thoughtpolice, @PhilipMetzger: are you okay with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, LGTM. I should have done this in the original PR, honestly, since I wanted to free up these names as early as possible so people could reuse co
. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG. I think for the future, we should just provide the aliases as built-in config, instead of defining them via clap. Then everyone is free to define them as is.
I hesitate to do that for two reasons:
|
I don't mind having a set of core aliases built-in but convenience aliases should be defined in the config. |
This way users can override
jj co
to meanjj new
if they want to get rid of the warning.Checklist
If applicable:
CHANGELOG.md